[pve-devel] [RFC proxmox-backup 1/1] api2/node/disks/zfs: instantiate import service

Stoiko Ivanov s.ivanov at proxmox.com
Wed Sep 16 14:14:18 CEST 2020


When creating a new zpool for a datastore, also instantiate an
import-unit for it. This helps in cases where '/etc/zfs/zool.cache'
get corrupted and thus the pool is not imported upon boot.

This patch needs the corresponding addition of 'zfs-import at .service' in
the zfsonlinux repository.

Suggested-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
 src/api2/node/disks/zfs.rs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs
index c5d6f6a6..0f0e4220 100644
--- a/src/api2/node/disks/zfs.rs
+++ b/src/api2/node/disks/zfs.rs
@@ -25,6 +25,8 @@ use crate::server::WorkerTask;
 
 use crate::api2::types::*;
 
+use crate::tools::systemd;
+
 pub const DISK_ARRAY_SCHEMA: Schema = ArraySchema::new(
     "Disk name list.", &BLOCKDEVICE_NAME_SCHEMA)
     .schema();
@@ -355,6 +357,9 @@ pub fn create_zpool(
             let output = crate::tools::run_command(command, None)?;
             worker.log(output);
 
+            let import_unit = format!("zfs-import@{}.service", systemd::escape_unit(&name, false));
+            systemd::enable_unit(&import_unit)?;
+
             if let Some(compression) = compression {
                 let mut command = std::process::Command::new("zfs");
                 command.args(&["set", &format!("compression={}", compression), &name]);
-- 
2.20.1






More information about the pve-devel mailing list