[pve-devel] [PATCH RFC guest-common/manager/docs] adapt calendar events to pbs/systemd style

Dominik Csapak d.csapak at proxmox.com
Thu Sep 10 14:57:06 CEST 2020


pbs cannot handle minute only calendar events
(because we support seconds there and hh:mm and mm:ss would be ambiguous)

so we want to eventually remove that in pve (in a future major version)
to have a consistent calendarevent syntax

for this we do 4 things here:

* transform such events when writing the replication config (to *:YYY)
* adapt the defaults in the gui (to include the hour as *)
* rewrite the docs to not mention that the hour is optional
* replace */x with 0/x since that works in systemd too

the parser still is the same, so existing config stay valid
and on the next config write, the syntax will automatically adapt
(this way we can have a parse/write cycle e.g. in an pve6to7 script
and can be sure we have the new syntax)

pve-guest-common:

Dominik Csapak (1):
  ReplicationConfig: transform schedules to include always hours

 PVE/ReplicationConfig.pm | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

pve-manager:

Dominik Csapak (2):
  ui: adapt/optimize calendar event examples
  ui: grid/Replication: change the default format of schedule text

 www/manager6/form/CalendarEvent.js | 6 +++---
 www/manager6/grid/Replication.js   | 7 ++++---
 2 files changed, 7 insertions(+), 6 deletions(-)

pve-docs:

Dominik Csapak (2):
  pvesr: fix calendar event examples
  pvesr: modify examples to fit with pbs style

 pvesr.adoc | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

-- 
2.20.1





More information about the pve-devel mailing list