[pve-devel] applied: [PATCH v2 firewall] introduce new icmp-type parameter

[Thomas Lamprecht]

On 29.05.20 14:22, Mira Limbeck wrote:
> Currently icmp types are handled via 'dport'. This is not documented
> anywhere except for a single line of comment in the code. To untangle
> the icmp-type handling from the dport handling a new 'icmp-type'
> parameter is introduced.
> 
> The valid 'icmp-type' values are limited to the names
> (icmp[v6]_type_names hash in the code, same as ip[6]tables provides).
> Type[/Code] values are not supported.
> 
> Support for ipv6-icmp is added to icmp-type parameter handling. This makes it
> possible to specify icmpv6 types via the GUI.
> 
> Signed-off-by: Mira Limbeck <m.limbeck at proxmox.com>
> ---
> v2:
>  - rebased on master
>  - removed type[/code] value support, now only names are accepted
> 
>  src/PVE/API2/Firewall/Rules.pm |  4 +++
>  src/PVE/Firewall.pm            | 50 +++++++++++++++++++++++++++++++++-
>  2 files changed, 53 insertions(+), 1 deletion(-)
> 
>

applied, thanks!