[pve-devel] [PATCH-SERIES/RFC manager 00/14] split up content view into a view for each type

Fabian Ebner f.ebner at proxmox.com
Wed Sep 2 13:03:23 CEST 2020


The goal of doing this is to have more flexibility/cleaner code for
content-type-dependent features in the content view. Now only buttons
that are useful for each content type are displayed. And it might make
sense to display different columns for different content types, e.g.
'parent' for cloned VM/CT images. The mechanism introduced in this series
(patch #13) is not used yet, suggestions for which columns to use for
which types are welcome.

API calls might be faster if only one type of content is requested.
The obvious drawback is that there is no view with all contents anymore.

The last patch is not directly related, but introduces the prune window
for backups, essentially copied over from the PBS code.

@Thomas: Hope this is not too far from what you had in mind.
Of course I can rebase the prune window patch on current master if prefer.

Fabian Ebner (14):
  config panel: allow new nodes to be added later
  storage panel/browser: use insertNodes function
  use separate view for each content type
  remove the now unneccessary grouping
  content view: allow specifying title bar elements for init
  turn nodename,storage,sm into object variables
  add upload button conditionally
  create and use TemplateView
  create and use BackupView
  get rid of unneccessary enableFn's
  create ImageView and use it for VM and CT images
  simplify reload call
  content view: allow specifying which columns to show on init
  backup view: add prune window

 www/manager6/Makefile                |   4 +
 www/manager6/panel/ConfigPanel.js    |  93 ++---
 www/manager6/storage/BackupView.js   |  96 ++++++
 www/manager6/storage/Browser.js      |  89 ++++-
 www/manager6/storage/ContentView.js  | 497 +++++----------------------
 www/manager6/storage/ImageView.js    |  74 ++++
 www/manager6/storage/TemplateView.js | 212 ++++++++++++
 www/manager6/window/Prune.js         | 230 +++++++++++++
 8 files changed, 836 insertions(+), 459 deletions(-)
 create mode 100644 www/manager6/storage/BackupView.js
 create mode 100644 www/manager6/storage/ImageView.js
 create mode 100644 www/manager6/storage/TemplateView.js
 create mode 100644 www/manager6/window/Prune.js

-- 
2.20.1






More information about the pve-devel mailing list