[pve-devel] [PATCH manager 04/14] remove the now unneccessary grouping

Fabian Ebner f.ebner at proxmox.com
Wed Sep 2 13:03:27 CEST 2020


since there are no grouping headers anymore, the situation
with the empty volid shouldn't happen anymore.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 www/manager6/storage/ContentView.js | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js
index c067d3e0..2c320bec 100644
--- a/www/manager6/storage/ContentView.js
+++ b/www/manager6/storage/ContentView.js
@@ -357,12 +357,6 @@ Ext.define('PVE.storage.ContentView', {
 	trackOver: false,
 	loadMask: false
     },
-    features: [
-	{
-	    ftype: 'grouping',
-	    groupHeaderTpl: '{name} ({rows.length} Item{[values.rows.length > 1 ? "s" : ""]})'
-	}
-    ],
     initComponent : function() {
 	var me = this;
 
@@ -630,9 +624,7 @@ Ext.define('PVE.storage.ContentView', {
 	    {
 		name: 'text',
 		convert: function(value, record) {
-		    // check for volid, because if you click on a grouping header,
-		    // it calls convert (but with an empty volid)
-		    if (value || record.data.volid === null) {
+		    if (value) {
 			return value;
 		    }
 		    return PVE.Utils.render_storage_content(value, {}, record);
@@ -641,9 +633,7 @@ Ext.define('PVE.storage.ContentView', {
 	    {
 		name: 'vdate',
 		convert: function(value, record) {
-		    // check for volid, because if you click on a grouping header,
-		    // it calls convert (but with an empty volid)
-		    if (value || record.data.volid === null) {
+		    if (value) {
 			return value;
 		    }
 		    let t = record.data.content;
-- 
2.20.1






More information about the pve-devel mailing list