[pve-devel] [PATCH v2 0/6] QEMU backup cancellation fixes

Stefan Reiter s.reiter at proxmox.com
Thu Oct 29 14:10:30 CET 2020


Some bugfixes for qmp_backup_cancel and create_backup_jobs, that would lead to
VM hangs, wrongly aborted backups or missing/bad error messages.

Now tested with all permutations of
* one vs two disks
* iothread enabled/disabled per disk
and running
    until sudo timeout -s SIGTERM 5s vzdump 100 --storage pbs; do; done
during lunch :)

Sent as seperate patches for review, last patch is for pve-qemu and contains the
changes squashed in with only one new file.

v2:
* fix some more issues (patches 1 and 5)
* fix releasing wrong AioContext after job_cancel_sync
* add patch-of-patches for easier apply


qemu: Stefan Reiter (5):
  PVE: fixup: drop CoMutex on error return
  PVE: Introduce generic CoCtxData struct
  PVE: Don't expect complete_cb to be called outside coroutine
  PVE: Don't call job_cancel in coroutines
  PVE: fix and clean up error handling for create_backup_jobs

 proxmox-backup-client.c |  20 +++-----
 proxmox-backup-client.h |   6 +++
 pve-backup.c            | 111 +++++++++++++++++++++++++++++-----------
 3 files changed, 93 insertions(+), 44 deletions(-)

qemu: Stefan Reiter (1):
  Several fixes for backup abort and error reporting

 ...ckup-proxmox-backup-patches-for-qemu.patch |  41 ++--
 ...irty-bitmap-tracking-for-incremental.patch |  10 +-
 ...ct-stderr-to-journal-when-daemonized.patch |   2 +
 ...d-sequential-job-transaction-support.patch |   1 +
 ...-transaction-to-synchronize-job-stat.patch |   2 +
 ...ore-coroutines-and-don-t-block-on-fi.patch |  94 +++++----
 ...n-up-error-handling-for-create_backu.patch | 187 ++++++++++++++++++
 debian/patches/series                         |   1 +
 8 files changed, 275 insertions(+), 63 deletions(-)
 create mode 100644 debian/patches/pve/0053-PVE-fix-and-clean-up-error-handling-for-create_backu.patch

-- 
2.20.1





More information about the pve-devel mailing list