[pve-devel] applied-series: [PATCH manager v2 1/5] ceph: split out pool set into own method

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 22 18:52:00 CEST 2020


On 19.10.20 12:39, Alwin Antreich wrote:
> to reduce code duplication and make it easier to add more options for
> pool commands.
> 
> Use a new rados object for each 'osd pool set', as each command can set
> an option independent of the previous commands success/failure. On
> failure a new rados object would need to be created and that will
> confuse task tracking of the REST environment.
> 
> Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
> ---
> Note:
>     v1 -> v2:
> 	* reorder patches, since pool create & set share common pool
> 	  options.
> 	* include new setpool API
> 
>  PVE/API2/Ceph.pm  | 17 +++++++----
>  PVE/Ceph/Tools.pm | 74 +++++++++++++++++++++++++----------------------
>  2 files changed, 52 insertions(+), 39 deletions(-)
> 
>

applied series, thanks! FYI: Did a followup refactoring to the part where the defaults
are deleted conditionally in the common option method.






More information about the pve-devel mailing list