[pve-devel] [PATCH 0/2] QEMU backup cancellation fixes

Stefan Reiter s.reiter at proxmox.com
Thu Oct 22 14:11:16 CEST 2020


Two smaller bugfixes for qmp_backup_cancel, that would lead to VM hangs or
wrongly aborted backups. Sent as seperate patches to highlight the changes, but
can probably be squashed into some of our other patches as well (lmk if I should
do that).

I also got dirty bitmap migrate working, but still needs some testing/cleanup.
I'd also like for upstream to give their final decision on the fix I sent, then
I'll confidently send that as well :)

@Dominik: If you apply these two patches, can you still reproduce the hang on
abort? I'm not sure we experienced the 'same' hang.


Stefan Reiter (2):
  PVE: Don't expect complete_cb to be called outside coroutine
  PVE: Don't call job_cancel in coroutines

 pve-backup.c | 33 ++++++++++++++++++++++++++++-----
 1 file changed, 28 insertions(+), 5 deletions(-)

-- 
2.20.1






More information about the pve-devel mailing list