[pve-devel] [PATCH-SERIES v2 manager] Make backup with IDs for non-existent guests visibly fail

[Fabian Ebner]

#1 and #2 are just cleanups

#3 and #4 make the necessary changes for the improved behavior
by ensuring that exec_backup_task will cleanly fail when there
is no plugin specified, and then including the orphaned IDs
without assigning them a plugin. This is closer to the behavior
of PVE 6.0 and ensures that the backup task is marked as failed,
and the mail notification includes an error for the orphaned IDs.

#5 ensures that the IDs are still numerically ordered when there
are non-existing guests

#6 and #7 are minor improvements and can be applied independently

#8 is an RFC and changes the data structure returned by get_included_guests


Changes from v1:
    * everything, as the approach is different


Fabian Ebner (8):
  remove unused variable
  remove out-of-date comment
  only use plugin after truthiness check
  backup: include IDs for non-existent guests
  order guest IDs numerically in exec_backup
  sort the skip list numerically
  simplify get_included_vmids function
  don't group by node in get_included_guests

 PVE/API2/Backup.pm                 |  23 ++--
 PVE/API2/BackupInfo.pm             |  18 +---
 PVE/API2/VZDump.pm                 |  19 +++-
 PVE/VZDump.pm                      |  68 +++++++-----
 test/vzdump_guest_included_test.pl | 163 ++++++++++++++++++++++++++---
 5 files changed, 212 insertions(+), 79 deletions(-)

-- 
2.20.1