[pve-devel] applied-series: [PATCH v2 0/7] Improve boot device/order configuration

[Thomas Lamprecht]

On 06.10.20 15:32, Stefan Reiter wrote:
> The goal of the series is to modernize boot order selection by allowing the user
> to specify arbitrary VM disks and devices in any order. Fixes #3010 and #3011.
> 
> First patch is a standalone cleanup. Tests are seperated into extra patches.
> 
> v2:
> * split qemu-server changes into seperate patches (hence changelog only here)
> * use order= property in boot: instead of standalone bootorder:
> ** update API and GUI to match
> * fix get_default_bootdevices and bootorder_from_legacy to *actually* match the
> old behaviour, as is now verified with the test
> => see GUI patch for changes there
> 
> 
> qemu-server: Stefan Reiter (6):
>   fix indentation
>   cfg2cmd: add test for legacy-style bootorder
>   add new 'boot' property format and introduce legacy conversion helpers
>   fix #3010: add 'bootorder' parameter for better control of boot
>     devices
>   api: add handling for new boot order format
>   cfg2cmd: add tests for new boot order property
> 
>  PVE/API2/Qemu.pm                       |  37 ++++-
>  PVE/CLI/qm.pm                          |   4 +-
>  PVE/QemuServer.pm                      | 207 ++++++++++++++++++++-----
>  PVE/QemuServer/Drive.pm                |  32 +++-
>  PVE/QemuServer/PCI.pm                  |   3 +-
>  PVE/QemuServer/USB.pm                  |  14 +-
>  test/cfg2cmd/bootorder-empty.conf      |  16 ++
>  test/cfg2cmd/bootorder-empty.conf.cmd  |  38 +++++
>  test/cfg2cmd/bootorder-legacy.conf     |  17 ++
>  test/cfg2cmd/bootorder-legacy.conf.cmd |  38 +++++
>  test/cfg2cmd/bootorder.conf            |  16 ++
>  test/cfg2cmd/bootorder.conf.cmd        |  38 +++++
>  12 files changed, 398 insertions(+), 62 deletions(-)
>  create mode 100644 test/cfg2cmd/bootorder-empty.conf
>  create mode 100644 test/cfg2cmd/bootorder-empty.conf.cmd
>  create mode 100644 test/cfg2cmd/bootorder-legacy.conf
>  create mode 100644 test/cfg2cmd/bootorder-legacy.conf.cmd
>  create mode 100644 test/cfg2cmd/bootorder.conf
>  create mode 100644 test/cfg2cmd/bootorder.conf.cmd
> 
> manager: Stefan Reiter (1):
>   ui: improve boot order editor with 'bootorder' support
> 
>  www/css/ext6-pve.css               |   4 +
>  www/manager6/qemu/BootOrderEdit.js | 355 ++++++++++++++++++-----------
>  www/manager6/qemu/Options.js       |  32 ++-
>  3 files changed, 257 insertions(+), 134 deletions(-)
> 



applied series, thanks!

I did a few smaller followups for the webinterface though, nothing big,
the only thing you may want to check out for the future is the use of
the defaults property for defaults covering all/most items:
https://docs.sencha.com/extjs/6.0.1/classic/Ext.grid.Panel.html#cfg-defaults