[pve-devel] [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column

[Aaron Lauterer]

On 10/1/20 5:10 PM, Thomas Lamprecht wrote:
> On 01.10.20 14:18, Aaron Lauterer wrote:
>> Allows 2 digits rule numbers to be visible in the column. Made it a bit
>> wider than needed to account for potentially wider font rendering on
>> different platforms.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>>   www/manager6/grid/FirewallRules.js | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
>> index ec2d1c84..42035129 100644
>> --- a/www/manager6/grid/FirewallRules.js
>> +++ b/www/manager6/grid/FirewallRules.js
>> @@ -629,7 +629,7 @@ Ext.define('PVE.FirewallRules', {
>>   		// similar to xtype: 'rownumberer',
>>   		dataIndex: 'pos',
>>   		resizable: false,
>> -		width: 23,
>> +		width: 42,
>>   		sortable: false,
>>   		align: 'right',
>>   		hideable: false,
>>
> 
> oh, and maybe you can try to switch that whole column definition away from fixed
> widths to relative "flex" only. Just needs to look OK on 720p and quite good on
> 1080p. It's not always possible, but most of the time it works out well and not
> using fixed widths is always nicer, IMO.
> 

good point. I'll take a look at it.