[pve-devel] applied: [PATCH storage] plugin: hooks: add explicit returns

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Nov 27 10:55:36 CET 2020


On 27.11.20 10:35, Fabian Ebner wrote:
> to avoid returning something unexpected. Finish what
> afeda182566292be15413d9b874720876eac14c9 already started for all the other
> plugins. At least for ZFS's on_add_hook this is necessary (adding a ZFS storage
> currently fails as reported here [0]), but it cannot hurt
> in the other places either as the only hooks we expect to return something
> currently are PBS's on_add_hook and on_update_hook.
> 
> [0]: https://forum.proxmox.com/threads/gui-add-zfs-storage-verification-failed-400-config-type-check-object-failed.79734/
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/Storage/CIFSPlugin.pm    | 6 ++++++
>  PVE/Storage/CephFSPlugin.pm  | 4 ++++
>  PVE/Storage/LVMPlugin.pm     | 2 ++
>  PVE/Storage/PBSPlugin.pm     | 2 ++
>  PVE/Storage/RBDPlugin.pm     | 4 ++++
>  PVE/Storage/ZFSPoolPlugin.pm | 2 ++
>  6 files changed, 20 insertions(+)
> 
>

applied, thanks!





More information about the pve-devel mailing list