[pve-devel] applied: [PATCH manager] ui: fix usage of findRecord

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 26 10:59:49 CET 2020


On 26.11.20 09:19, Dominik Csapak wrote:
> findRecord does not match exactly, but only at the beginning and
> case insensitive, by default. Change all calls to be case sensitive
> and an exactmatch (we never want the default behaviour afaics).
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/manager6/dc/Backup.js              | 4 ++--
>  www/manager6/dc/SecurityGroups.js      | 2 +-
>  www/manager6/form/ACMEAPISelector.js   | 2 +-
>  www/manager6/form/NodeSelector.js      | 2 +-
>  www/manager6/form/VMCPUFlagSelector.js | 2 +-
>  www/manager6/form/ViewSelector.js      | 2 +-
>  www/manager6/grid/BackupView.js        | 6 ++++--
>  www/manager6/grid/FirewallAliases.js   | 2 +-
>  www/manager6/panel/IPSet.js            | 2 +-
>  www/manager6/window/Backup.js          | 2 +-
>  10 files changed, 14 insertions(+), 12 deletions(-)
> 
>

applied, thanks! as talked off-list, I would find it more ergonomic to add a
"findExactRecord" which combines the advantages of the existing findExact and
findRecord methods.

https://docs.sencha.com/extjs/6.0.1/classic/src/AbstractStore.js.html#line341






More information about the pve-devel mailing list