[pve-devel] [PATCH manager v2 0/8] ceph: allow pools settings to be changed

Dominik Csapak d.csapak at proxmox.com
Tue Nov 24 14:53:17 CET 2020


high level comment

it seems the series depends on pg autoscaling to be enabled, but on my
nautilus installation it was not

so i'd say we have to handle that by not querying autoscaling settings
if it is disabled or wrapping the mon call in an eval, else the whole 
pool view does not work
(i get an 500)

On 11/24/20 11:58 AM, Alwin Antreich wrote:
> This set allows to edit pools via GUI & CLI. This should make it easier
> for users to adjust pool settings, since they don't have to go the ceph
> tool route.
> 
> v1 -> v2:
>      - move pools endpoint to a subclass
>      - add pg autsocale status and settings
>      - rework and flatten the grid view of ceph pools
>      - rework the create input panel
>      - add an edit button using the reworked input panel
>      - fix borken add_storages
>      - extend setp_pool function to avoid a race condition
>      - remove the pg_autoscale_mode default to allow Ceph's setting to
>        take precedence
> 
> 
> Alwin Antreich (8):
>    api: ceph: subclass pools
>    ceph: add get api call for single pool
>    ceph: add autoscale_status to api calls
>    ceph: gui: add autoscale & flatten pool view
>    ceph: gui: rework pool input panel
>    ceph: schema: change min. required PG count to 1
>    ceph: remove the pg_autoscale_mode default
>    fix: ceph: always set pool size first
> 
>   PVE/API2/Ceph/Makefile    |   1 +
>   PVE/API2/Ceph.pm          | 380 +------------------------
>   PVE/API2/Ceph/POOLS.pm    | 572 ++++++++++++++++++++++++++++++++++++++
>   PVE/CLI/pveceph.pm        |  12 +-
>   PVE/Ceph/Tools.pm         |  70 ++++-
>   www/manager6/ceph/Pool.js | 405 +++++++++++++++++++--------
>   6 files changed, 950 insertions(+), 490 deletions(-)
>   create mode 100644 PVE/API2/Ceph/POOLS.pm
> 






More information about the pve-devel mailing list