[pve-devel] [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments
Dominik Csapak
d.csapak at proxmox.com
Tue Nov 24 10:09:28 CET 2020
implement editing/showing notes from pve side
for directory and pbs storages
this series technically consists of a breaking api change
(comments -> notes) in content listing, but since we only just built
packages with the relevant commits, this should be ok...
i also omitted the suggested 'snapshot list' part of proxmox-backup
but will look into implementing an invisible alias for the clicommand
in rust soon
changes from v1:
* rename all occurences of 'comment' to 'notes' where possible
(everywhere except the snapshots api of pbs)
* split patches so that pbs ones could be applied later
apply order/dependency:
pbs patches (can be applied later):
pve-manager 3/3 depends on pve-storage 4/4 depends on proxmxo-backup
else:
pve-manager 1/3 depends on pve-storage 1/4
pve-manager 2/3 depends on pve-storage 2,3/4
proxmox-backup:
Dominik Csapak (1):
client: add 'snapshot notes show/update' command
src/bin/proxmox-backup-client.rs | 1 +
src/bin/proxmox_backup_client/mod.rs | 2 +
src/bin/proxmox_backup_client/snapshot.rs | 126 ++++++++++++++++++++++
3 files changed, 129 insertions(+)
create mode 100644 src/bin/proxmox_backup_client/snapshot.rs
pve-storage:
Dominik Csapak (4):
rename comment to notes
api2/storage/content: change to volume_size_info and add return
properties
Storage/Plugin: add get/update_volume_comment and implement for dir
Storage/PBSPlugin: implement get/update_volume_notes for pbs
PVE/API2/Storage/Content.pm | 96 ++++++++++++++++++++++++++++++++++---
PVE/Storage.pm | 20 ++++++++
PVE/Storage/DirPlugin.pm | 30 ++++++++++++
PVE/Storage/PBSPlugin.pm | 22 ++++++++-
PVE/Storage/Plugin.pm | 22 +++++++--
5 files changed, 177 insertions(+), 13 deletions(-)
pve-manager:
Dominik Csapak (3):
ui: change comment column to notes
ui: add ability to show and edit comments for backups
ui: enable notesedit for pbs
www/manager6/grid/BackupView.js | 47 +++++++++++++++++++++++++++--
www/manager6/storage/Browser.js | 2 +-
www/manager6/storage/ContentView.js | 12 ++++----
3 files changed, 51 insertions(+), 10 deletions(-)
--
2.20.1
More information about the pve-devel
mailing list