[pve-devel] applied: [PATCH manager v2 0/2] add UI support for editing metric servers

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 23 07:11:38 CET 2020


On 20.11.20 15:12, Dominik Csapak wrote:
> Adds the typical sectionconfig api entry points, as well as a basic
> CRUD ui under Datacenter -> Metric Server
> 
> the next step is to adapt the documentation to no refer to editing the
> config anymore, adding some more useful information, as well
> as adding a onlinehelp link to the ui
> 
> changes from v1:
> * integrated thomas feedback, aside from using createSchema for return values
>   (i'll look at it soon)
> * ran eslint -f over dc/MetricServerView.js
> 
> Dominik Csapak (2):
>   api2/cluster: add 'metricserver' api endpoints
>   ui: add MetricServerView to Datacenter
> 
>  PVE/API2/Cluster.pm                    |   7 +
>  PVE/API2/Cluster/Makefile              |   1 +
>  PVE/API2/Cluster/MetricServerConfig.pm | 228 ++++++++++++++
>  www/manager6/Makefile                  |   1 +
>  www/manager6/dc/Config.js              |   6 +
>  www/manager6/dc/MetricServerView.js    | 397 +++++++++++++++++++++++++
>  6 files changed, 640 insertions(+)
>  create mode 100644 PVE/API2/Cluster/MetricServerConfig.pm
>  create mode 100644 www/manager6/dc/MetricServerView.js
> 


applied, thanks! I did followups for the remaining comments I had on v1 that
went lost.






More information about the pve-devel mailing list