[pve-devel] applied: [PATCH pve-storage 3/3 v2] lvmthin: Match snapshot remove regex to allowed names

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 16 18:26:09 CET 2020


On 28.10.20 11:04, Dominic Jäger wrote:
> We allow snapshot names that match pve-configid but during qm destroy we have
> not removed all snapshots that match pve-configid so far. For example, the name
> x-y was allowed but the resulting snap_vm-105-disk-0_x-y was not removed.
> 
> Reported-by: Hannes Laimer <h.laimer at proxmox.com>
> Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
> ---
> Requires the pve-common patches
> 
> v1->v2: Use the now public regex instead of the verify function
> 
> The "use constant" variant requires a backslash
> ${\PVE::JSONSchema::CONFIGID_RE} for each usage and the getter/method variant
> requires postponed regular subexpressions m/^(??{get_configid_re()})$/), so
> "our" looked the most simple to me.
> 
>  PVE/Storage/LvmThinPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!






More information about the pve-devel mailing list