[pve-devel] [PATCH-SERIES v3 manager] split up content view into a view for each type
Fabian Ebner
f.ebner at proxmox.com
Fri Nov 13 14:16:13 CET 2020
The goal of doing this is to have more flexibility/cleaner code for
content-type-dependent features in the content view. Now only buttons
that are useful for each content type are displayed. And it might make
sense to display different columns for different content types, e.g.
'parent' for cloned VM/CT images. (see #16)
API calls might be faster if only one type of content is requested.
The obvious drawback is that there is no view with all contents anymore.
The first patch is not directly related. It fixes the extension filters
when selecting a file to upload.
The last four patches are not directly related, but introduce grouping of backups
and introduce the prune window, which was essentially copied from the PBS code.
The prune window patch depends on this patch (otherwise it would error
out when all numberfields are cleared):
https://lists.proxmox.com/pipermail/pve-devel/2020-November/045916.html
Changes from v2:
* rebase on current master and deal with the new comment column
* fix backup grouping for PBS storages
* base prune window on the current prune window from PBS (there were
some changes in the time since I sent v2)
Fabian Ebner (20):
fix extension filter for upload window
config panel: allow new nodes to be added later
storage panel/browser: use insertNodes function
add CD ROM and lxc icons for treelist-item-icon
use separate view for each content type
remove the now unnecessary grouping by content type
remove the now unneccessary content type column
content view: allow specifying title bar elements for init
turn {nodename,storage,sm} into object variables
add upload button conditionally
create and use TemplateView
create and use BackupView
get rid of unneccessary enableFn's
create ImageView and use it for VM and CT images
simplify reload call
content view: allow specifying which columns to show on init
group backups by backup groups in backup view
allow child classes of ContentView to specify their own listeners
add CSS for button in grid's group header
backup view: add prune window
www/css/ext6-pve.css | 28 ++
www/manager6/Makefile | 4 +
www/manager6/panel/ConfigPanel.js | 93 ++---
www/manager6/storage/BackupView.js | 128 +++++++
www/manager6/storage/Browser.js | 97 ++++-
www/manager6/storage/ContentView.js | 551 +++++++--------------------
www/manager6/storage/ImageView.js | 74 ++++
www/manager6/storage/TemplateView.js | 215 +++++++++++
www/manager6/window/Prune.js | 306 +++++++++++++++
9 files changed, 1018 insertions(+), 478 deletions(-)
create mode 100644 www/manager6/storage/BackupView.js
create mode 100644 www/manager6/storage/ImageView.js
create mode 100644 www/manager6/storage/TemplateView.js
create mode 100644 www/manager6/window/Prune.js
--
2.20.1
More information about the pve-devel
mailing list