[pve-devel] [PATCH installer 1/3] memorize keyboard layout selection
Stoiko Ivanov
s.ivanov at proxmox.com
Tue Nov 10 15:15:28 CET 2020
currently when using the previous/next buttons the keyboard layout gets
defined based on the detected/selected country, even if it was set to a
different value explicitly.
This patch changes the behaviour to only update the layout and set it in
the installer if it got actively changed, or if a different country was
selected
Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
proxinstall | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 9879df4..9977f44 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2549,6 +2549,8 @@ sub get_device_desc {
}
}
+my $last_layout;
+my $country_layout;
sub update_layout {
my ($cb, $kmap) = @_;
@@ -2562,7 +2564,14 @@ sub update_layout {
$i++;
}
- $cb->set_active($ind || $def || 0);
+ my $val = $ind || $def || 0;
+
+ if (!defined($kmap)) {
+ $last_layout //= $val;
+ } elsif (!defined($country_layout) || $country_layout != $val) {
+ $last_layout = $country_layout = $val;
+ }
+ $cb->set_active($last_layout);
}
my $lastzonecb;
@@ -2699,6 +2708,7 @@ sub create_password_view {
}
+my $installer_kmap;
sub create_country_view {
cleanup_view();
@@ -2744,11 +2754,16 @@ sub create_country_view {
$kmapcb->signal_connect ('changed' => sub {
my $sel = $kmapcb->get_active_text();
+ $last_layout = $kmapcb->get_active();
if (my $kmap = $cmap->{kmaphash}->{$sel}) {
my $xkmap = $cmap->{kmap}->{$kmap}->{x11};
my $xvar = $cmap->{kmap}->{$kmap}->{x11var};
$keymap = $kmap;
+ return if (defined($installer_kmap) && $installer_kmap eq $kmap);
+
+ $installer_kmap = $keymap;
+
if (! $opt_testmode) {
syscmd ("setxkbmap $xkmap $xvar");
}
--
2.20.1
More information about the pve-devel
mailing list