[pve-devel] [PATCH V2 pve-manager] API2: Network: display vnets in any_bridge

[Alexandre DERUMIER]

>>nicer, IMO :) Is there still stuff open for pve-network repo, or is
>>something coming quite soon?

It's missing this patch:
https://www.mail-archive.com/pve-devel@pve.proxmox.com/msg38598.html

But that's all.


Maybe the permissions management will need some polish before final release
Mainly in gui, I think it's ok in pve-network api.


But for a first beta, all features should work fine.





----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 27 Mars 2020 09:48:05
Objet: Re: [pve-devel] [PATCH V2 pve-manager] API2: Network: display vnets in any_bridge

Alexandre Derumier 
Ingénieur système et stockage 

Manager Infrastructure 


Fixe : +33 3 59 82 20 10 



125 Avenue de la république 
59110 La Madeleine 
[ https://twitter.com/OdisoHosting ] [ https://twitter.com/mindbaz ] [ https://www.linkedin.com/company/odiso ] [ https://www.viadeo.com/fr/company/odiso ] [ https://www.facebook.com/monsiteestlent ] 

[ https://www.monsiteestlent.com/ | MonSiteEstLent.com ] - Blog dédié à la webperformance et la gestion de pics de trafic 

----- Mail original ----- 
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com> 
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com> 
Envoyé: Vendredi 27 Mars 2020 07:48:07 
Objet: Re: [pve-devel] [PATCH V2 pve-manager] API2: Network: display vnets in any_bridge 

On 3/26/20 3:07 AM, Alexandre Derumier wrote: 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
> --- 
> PVE/API2/Network.pm | 8 ++++++++ 
> 1 file changed, 8 insertions(+) 
> 
> diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm 
> index 4c691879..32ab8ebd 100644 
> --- a/PVE/API2/Network.pm 
> +++ b/PVE/API2/Network.pm 
> @@ -18,6 +18,7 @@ use base qw(PVE::RESTHandler); 
> 
> my $have_sdn; 
> eval { 
> + require PVE::Network::SDN; 
> require PVE::Network::SDN::Zones; 
> require PVE::Network::SDN::Controllers; 
> $have_sdn = 1; 
> @@ -246,6 +247,13 @@ __PACKAGE__->register_method({ 
> ($type eq 'bridge' || $type eq 'OVSBridge')); 
> delete $ifaces->{$k} if !$match; 
> } 
> + 
> + if ($have_sdn && $param->{type} eq 'any_bridge') { 
> + my $vnets = PVE::Network::SDN::get_local_vnets(); 
> + map { 
> + $ifaces->{$_} = $vnets->{$_}; 
> + } keys %$vnets; 
> + } 
> } 
> 
> return PVE::RESTHandler::hash_to_array($ifaces, 'iface'); 
> 

nicer, IMO :) Is there still stuff open for pve-network repo, or is 
something coming quite soon? 

Because this needs bumping, and I'd do that depending on how your 
plans about sending new stuff are.