[pve-devel] applied-series: [PATCH V2 pve-manager 0/3] add conditionnal sdn GUI

[Alexandre DERUMIER]

Look nice ! :)


----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Jeudi 26 Mars 2020 16:21:39
Objet: applied-series: [pve-devel] [PATCH V2 pve-manager 0/3] add conditionnal sdn GUI

On 3/11/20 3:05 AM, Alexandre Derumier wrote: 
> Patch 1 is still the same 
> Patch 2 enable the menu in datacenter if pve-network is installed 
> 

Applied series. 
I saw your new proposal about icons a bit to late (but the site looks 
nice). 

I replaced the VNet one with almost the same from the free parts of 
font-awesome 5: 
https://github.com/FortAwesome/Font-Awesome/blob/ce084cb3463f15fd6b001eb70622d00a0e43c56c/svgs/solid/network-wired.svg 

For controller I used: 
https://fontawesome.com/v4.7.0/icon/crosshairs 

For Zones: 
https://fontawesome.com/v4.7.0/icon/th 

And for SDN itself I did a quick undirected graph with graphviz dot: 
https://git.proxmox.com/?p=pve-manager.git;a=blob;f=www/images/icon-sdn.svg;h=6db1749a25322c8c75f4dbd3e0db7416d27216f9;hb=3c18c32eac996012f3cd1b61d5143eb7279f0787 

Which IMO looks OK enough. 

Hope that works too for you, didn't want to make to much of a fuzz 
about the icons, but from experience: the first chosen one stay almost 
always for ever :) 

cheers and thanks!