[pve-devel] applied: [PATCH access-control v2 3/5] Auth/AD: make PVE::Auth::AD a subclass of PVE::Auth::LDAP

[Thomas Lamprecht]

On 3/13/20 1:18 PM, Dominik Csapak wrote:
> this makes it much easier to reuse the sync code from LDAP in AD.
> The 'authenticate_user' sub is still the same, but we now
> can still use the get_users and get_groups functionality of LDAP
> 
> in the case of AD, the user_attr is optional in the config
> (would have been a breaking change) but we set it
> to default to 'sAMAccountName'
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * group_attr -> group_name_attr
>  PVE/Auth/AD.pm | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 

applied, thanks!