[pve-devel] applied: [PATCH access-control v2 2/5] Auth/LDAP: add get_{users, groups} subs for syncing

Thomas Lamprecht t.lamprecht at proxmox.com
Sat Mar 21 16:24:16 CET 2020


On 3/13/20 1:18 PM, Dominik Csapak wrote:
> this adds the subs which actually query the LDAP for users/groups
> and returns the value in format which makes it easy to insert
> in our parsed user.cfg
> 
> when we find a user/groupname which cannot be in our config,
> we warn the verification error
> 
> for groups, we append "-$realm" to the groupname, to lower the chance of
> accidental overwriting of existing groups (this will be documented
> in the api call since it technically does not prevent overwriting, just
> makes it more unlikely)
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changs from v1:
> * better variable naming (less confusion)
> * no defaults for enable/expire (let the api call and user.cfg handle this)
> * correct accidental condition reversing (!wantarray) -> (wantarray)
> 
>  PVE/Auth/LDAP.pm | 132 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 132 insertions(+)
> 

applied, thanks!





More information about the pve-devel mailing list