[pve-devel] [PATCH v2 qemu-server 3/3] migrate: add live-migration of replicated disks

[Stefan Reiter]

On 17/03/2020 12:40, Thomas Lamprecht wrote:
> On 3/17/20 11:21 AM, Stefan Reiter wrote:
>>> +            $local_volumes->{$opt} = $conf->{${opt}};
>>
>> Does $conf->{${opt}} have too many brackets or is this another arcane perl syntax I've yet to discover? (iow. why not just $conf->{$opt} ?)
> 
> It's not that arcane, you surely used it sometimes, for example:
> 
> * in strings to separate variable from text: "${foo}bar"
> * to treat a hashrefs element as hash: keys %{$foo->{bar}}
> * to treat a hashrefs element as array: @{$foo->{bar}}
> 
> so yes, it isn't useful here and would be nicer to just be $opt, but
> ${opt} is the same thing :)
> 

I assumed that's what's going on, but with Perl you never know and I'd 
only seen it in strings - the hashref stuff is a bit different IMO.

But thanks for clearing it up :)