[pve-devel] applied: [PATCH v4 qemu-server] Change format for unused drives

[Thomas Lamprecht]

On 3/16/20 10:10 AM, Fabian Grünbichler wrote:
> On March 12, 2020 11:19 am, Fabian Ebner wrote:
>> and make it match with what parse_drive does. Even though the 'real' format
>> was pve-volume-id, callers already expected that parse_drive returns a hash
>> with a valid 'file' key (e.g. PVE/API2/Qemu.pm:1147ff).
>>
>> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
>> ---
>>
>> This is the last patch left over from the series
>> refactoring the drive code [0], although not directly related.
>>
>> [0]: https://pve.proxmox.com/pipermail/pve-devel/2020-March/042007.html
>>
>> Changes from v3:
>>     * make sure the format describes a hash with a 'file' key
>>       as that's what callers expect
>>
>>  PVE/QemuServer/Drive.pm | 15 +++++++++++++--
>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>

> [...]
> 
> that being said - the patch as is LGTM and the above can be done as 
> follow-up just as well:
> 
> Reviewed-By: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> 


with that, applied, thanks!