[pve-devel] [PATCH common v2] inotify/interfaces: ensure cidr, address and netmask are set correctly

[Alexandre DERUMIER]

Just tested, works fine !

>>Plus mine always has the cidr/cidr6m I 
>>fixed a issue in the test system which prevented us from testing that: 
>>https://git.proxmox.com/?p=pve-common.git;a=commitdiff;h=ffe0b0e0756c17e06735e0e8ef681f2317a555ef 

Thanks, I didn't known how to handle this

>> in my patch, for the test, I have added an extra interface eth2 with "address <cidr>". 

>>makes sense to do! 


I have send an extra patch for the test, on top of your patch

----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Vendredi 13 Mars 2020 11:34:59
Objet: Re: [pve-devel] [PATCH common v2] inotify/interfaces: ensure cidr, address and netmask are set correctly

On 3/13/20 11:24 AM, Alexandre DERUMIER wrote: 
> Seem that you have done it like me :) 
> 

Mine also normalizes netmasks, i.e., 255.255.255.0 -> 24, for the 
address + mask only case. Plus mine always has the cidr/cidr6m I 
fixed a issue in the test system which prevented us from testing that: 
https://git.proxmox.com/?p=pve-common.git;a=commitdiff;h=ffe0b0e0756c17e06735e0e8ef681f2317a555ef 


But the rest is similar, yeah :) 

> in my patch, for the test, I have added an extra interface eth2 with "address <cidr>". 

makes sense to do!