[pve-devel] [PATCH guest-common] make GuestHelpers a subclass of Exporter

[Thomas Lamprecht]

On 3/12/20 10:57 AM, Dominik Csapak wrote:
> or else the Exports will not work
> 
> found by hotplugging nics with current master from qemu-server
> which resulted in a
> 'undefined subroutine &PVE::QemuServer::safe_string_ne'
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/GuestHelpers.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/PVE/GuestHelpers.pm b/PVE/GuestHelpers.pm
> index 916f19f..1688c5c 100644
> --- a/PVE/GuestHelpers.pm
> +++ b/PVE/GuestHelpers.pm
> @@ -9,6 +9,8 @@ use PVE::Storage;
>  use POSIX qw(strftime);
>  use Scalar::Util qw(weaken);
>  
> +use base qw(Exporter);
> +
>  our @EXPORT_OK = qw(safe_string_ne safe_boolean_ne safe_num_ne typesafe_ne);
>  
>  # We use a separate lock to block migration while a replication job
> 

applied, thanks! `perl -wc` doesn't catches this :( Oguz neither ;)