[pve-devel] applied: [PATCH v2 guest-common] abstractconfig: add prototype for get_backup_volumes

Aaron Lauterer a.lauterer at proxmox.com
Tue Mar 10 12:51:02 CET 2020


LGTM thanks :)

On 3/10/20 12:20 PM, Thomas Lamprecht wrote:
> On 2/27/20 11:01 AM, Aaron Lauterer wrote:
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>>
>> v1[0] -> v2:
>> given the feedback from Fabian I
>> * changed name of the method
>> * added more details as to what implementations should return
>>
>> [0] https://pve.proxmox.com/pipermail/pve-devel/2020-January/041267.html
>>
>>
>>   PVE/AbstractConfig.pm | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
> 
> applied with a followup adapting the comment, besides the correction you proposed[0]
> I also adapted indentation and wording a bit - holler if something is off.
> Thanks!
> 
> [0]: https://pve.proxmox.com/pipermail/pve-devel/2020-March/042070.html
> 




More information about the pve-devel mailing list