[pve-devel] [PATCH v2 guest-common 4/5] abstractconfig: add partial_fast_plug
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Mar 10 11:22:09 CET 2020
On 2/19/20 5:07 PM, Oguz Bektas wrote:
> allows partial fast plugging of functions as defined in the
> $partial_fast_plug_option in qemuserver (and possibly lxc later on)
>
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
>
> v1->v2:
> * rename get_partial_fast_plug_map -> get_partial_fast_plug_option
> * rename variables in partial_fast_plug for readability/understandability
> * return $changes instead of $changes_left
> * more verbose comment
>
> PVE/AbstractConfig.pm | 43 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
Applied, with two followups:
1. you missed to add the "use PVE::GuestHelperS", it worked by luck as the
using sites (qemu-server, pve-container) already used that.
2. added early return if $opt was not defined in $partial_fast_plug_config,
this allows to make the code in the using sites a bit more easier (see
replies to other patches)
More information about the pve-devel
mailing list