[pve-devel] applied: [PATCH manager 1/3] fix #2611: gui: use backendUnit and pretty renderer

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Mar 6 20:20:43 CET 2020


On 2/25/20 4:32 PM, Stefan Reiter wrote:
> Slightly confusing with the units:
> * Backend stores values in KiB/s
> * Frontend displays MiB/s (which is a good choice when considering
>   current generation network speeds as opposed to huge KiB numbers IMO)
> * Renderer previously showed no units, which would usually be interpreted
>   as Bytes/s
> 
> So add a pretty renderer that shows units and set backendUnit to submit
> correctly converted values.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  www/manager6/dc/OptionView.js | 38 +++++++++++++++++++++++++++++------
>  1 file changed, 32 insertions(+), 6 deletions(-)
> 


applied, thanks! refactored the render to a map + join and shaved of
10 LOC




More information about the pve-devel mailing list