[pve-devel] [PATCH qemu-server 1/3] Rename parameter 'volname' to 'volinfo'

[Fabian Grünbichler]

On March 5, 2020 11:57 am, Fabian Ebner wrote:
> Any feedback for these patches?

LGTM, but
- needs a rebase
- small nit regarding comment
- I'd squash #1 and #2, since the variable in question is currently 
  unused ;)

thanks!

> 
> On 1/8/20 11:28 AM, Fabian Ebner wrote:
>> since it is not just the name but a hash containing
>> information about the volume
>> 
>> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
>> ---
>>   PVE/QemuMigrate.pm | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
>> index 0353458..1de1540 100644
>> --- a/PVE/QemuMigrate.pm
>> +++ b/PVE/QemuMigrate.pm
>> @@ -313,7 +313,7 @@ sub sync_disks {
>>   	    $sharedvm = 0; # there is a non-shared disk
>>   
>>   	    PVE::Storage::foreach_volid($dl, sub {
>> -		my ($volid, $sid, $volname) = @_;
>> +		my ($volid, $sid, $volinfo) = @_;
>>   
>>   		$local_volumes->{$volid}->{ref} = 'storage';
>>   	    });
>> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>