[pve-devel] applied: [PATCH ifupdown2] add ifupdown2-pre.service service

[Alexandre DERUMIER]

>>The dependency ordering ones? FYI, we did already try to upstream
>>that:
>>https://github.com/CumulusNetworks/ifupdown2/pull/68

oh, I totally miss this. 


>>But cumulus devs closed quite a few of Wolfgangs tries by force pushing
>>to master a few times, which makes github close all pull requests...
>>But you seem a bit more lucky to get stuff into, so maybe it gets done
>>this time ^^

Yep, maybe because the main ifupdown2 dev is French too ;)

Will do it tomorrow, I'll keep you in touch.


----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 4 Mars 2020 18:03:53
Objet: Re: applied: [pve-devel] [PATCH ifupdown2] add ifupdown2-pre.service service

On 3/4/20 5:59 PM, Alexandre DERUMIER wrote: 
>>> applied, thanks! Would you like to look into up-streaming this to 
>>> ifupdown2? 
> 
> yes,sure. 
> I'll also try to push other changes in networking.service 

The dependency ordering ones? FYI, we did already try to upstream 
that: 
https://github.com/CumulusNetworks/ifupdown2/pull/68 

But cumulus devs closed quite a few of Wolfgangs tries by force pushing 
to master a few times, which makes github close all pull requests... 
But you seem a bit more lucky to get stuff into, so maybe it gets done 
this time ^^ 

Thanks! 

> 
> ----- Mail original ----- 
> De: "Thomas Lamprecht" <t.lamprecht at proxmox.com> 
> À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com> 
> Envoyé: Mercredi 4 Mars 2020 14:50:52 
> Objet: applied: [pve-devel] [PATCH ifupdown2] add ifupdown2-pre.service service 
> 
> On 2/19/20 12:47 PM, Alexandre Derumier wrote: 
>> ifupdown1 have a service to launch "udevadm settle", 
>> to be sure that networking devices are correctly setup 
>> before networking service is started. 
>> 
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920623 
>> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
>> --- 
>> ...ervice-fix-dependencies-and-ordering.patch | 52 ++++++++++++++++--- 
>> 1 file changed, 45 insertions(+), 7 deletions(-) 
>> 
> 
> 
> applied, thanks! Would you like to look into up-streaming this to 
> ifupdown2? 
> 
>