[pve-devel] [PATCH manager] ceph: make all service name regexes the same

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Mar 4 15:39:01 CET 2020


On 2/24/20 4:32 PM, Dominik Csapak wrote:
> instead of having multiple regexes in various places for the name,
> define a 'SERVICE_REGEX' in PVE::Ceph::Services, and use that
> everywhere in the api where we need it
> 
> additionally limit new sevices to 200 characters, since
> systemd units have a limit of 256 characters[0] (including suffix), and
> 200 seems to be enough.
> 
> users can now create ceph services on machines with hostnames
> longer than 32 characters
> 
> 0: https://www.freedesktop.org/software/systemd/man/systemd.unit.html
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> replaces my patch "ceph: increase allowed service names to 63 characters"
> 
>  PVE/API2/Ceph.pm     | 6 +++---
>  PVE/API2/Ceph/MDS.pm | 5 +++--
>  PVE/API2/Ceph/MGR.pm | 5 +++--
>  PVE/API2/Ceph/MON.pm | 5 +++--
>  PVE/Ceph/Services.pm | 4 +++-
>  5 files changed, 15 insertions(+), 10 deletions(-)
> 

applied, thanks!




More information about the pve-devel mailing list