[pve-devel] [PATCH http-server 1/1] increase allowed spiceport range

[Dominik Csapak]

On 3/3/20 10:25 AM, Thomas Lamprecht wrote:
> On 3/2/20 10:32 AM, Dominik Csapak wrote:
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>>   PVE/APIServer/AnyEvent.pm | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm
>> index 3ce948f..4bac1ca 100644
>> --- a/PVE/APIServer/AnyEvent.pm
>> +++ b/PVE/APIServer/AnyEvent.pm
>> @@ -808,7 +808,7 @@ sub handle_spice_proxy_request {
>>   
>>       eval {
>>   
>> -        die "Port $spiceport is not allowed" if ($spiceport < 61000 || $spiceport > 61099);
>> +        die "Port $spiceport is not allowed" if ($spiceport < 61000 || $spiceport > 61999);
> 
> it could make sense to move this check, or a sane call about what range is
> allowed to pve-common, so that we can avoid two different places with the
> same hardcoded value? PVE::Tools is already in use here anyway.

yeah, makes sense, i'll send a v2

> 
>>   
>>   	my $clientip = $reqstate->{peer_host};
>>   	my $r = $reqstate->{request};
>>
>