[pve-devel] Hi, did you have time to review my last patches ?

[Alexandre DERUMIER]

>>I was one time off work, that's why there were no reviews from me. 
>>Others seemed not having to much time either.. I'll try to catch up soon. 

Ok, no problem. It was holiday period in France too.


>>in general it can be easier to track what belongs together, yes. 
>>But I wouldn't resent the ifupdown2 series just for that.. 

Ok. I had sent differents series, because it was fixing differents bugs for differents proxmox users on the forum, not related.

Here a summary if it's help (I think I don't have forget nothing):

ifupdown2 : patch to wait udev interface renaming at boot:
   https://pve.proxmox.com/pipermail/pve-devel/2020-February/041844.html

ifupdown2: fix forwarding issue (was working in ifupdown2 1.0, but lost in 2.0. already applied in master-next)
   https://pve.proxmox.com/pipermail/pve-devel/2020-February/041941.html

ifupdown2: ovs plugin
   https://pve.proxmox.com/pipermail/pve-devel/2020-February/041887.html
with related pve-common to fix (auto .. )
   https://pve.proxmox.com/pipermail/pve-devel/2020-February/041892.html
and optionnal pve-common ovs cleanup
   https://pve.proxmox.com/pipermail/pve-devel/2020-February/041798.html


sdn:
pve-common : hooks on tap_create|plug  (needed for my last applied pve-network patches)
  https://pve.proxmox.com/pipermail/pve-devel/2020-February/041677.html
pve-manager: display vnets in bridgeselector
  https://pve.proxmox.com/pipermail/pve-devel/2020-February/041679.html

pve-manager: enable sdn gui with checking pve-network api
  https://pve.proxmox.com/pipermail/pve-devel/2020-February/041804.html



Other things:

ovs 2.12 :
  https://pve.proxmox.com/pipermail/pve-devel/2020-February/041731.html

pve-common: an rfc to use cidr in /etc/network/interfaces + multiple ip by interfaces
https://pve.proxmox.com/pipermail/pve-devel/2020-February/041866.html


----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Lundi 2 Mars 2020 10:39:32
Objet: Re: [pve-devel] Hi, did you have time to review my last patches ?

Hi, 

On 3/2/20 8:42 AM, Alexandre DERUMIER wrote: 
> Hi, 
> 
> I have send a lot of patches last weeks (mainly network, ifupdown2,ovs,sdn ...). 
> 
> did you have time to review them ? 

I was one time off work, that's why there were no reviews from me. 
Others seemed not having to much time either.. I'll try to catch up soon. 

> do you want that I merge differents series for same package for easier review ? (I'm think about ifupdown2 for example, where I have multiple series for differents bug) 

in general it can be easier to track what belongs together, yes. 
But I wouldn't resent the ifupdown2 series just for that..