[pve-devel] [PATCH Fix: CentOS 8 lxc start After update & upgrade PVE 5.4 1/1] Fix: CentOS 8 After Update & Upgrade PVE-5.4

[Oguz Bektas]

On Mon, Mar 02, 2020 at 03:20:50PM +0100, Moayad Almalat wrote:
> Hi,
> 
> Yeah it's in PVE 5.x, i already added in the Subject PVE 5.4.

yes i see. you should still add the name of the
branch i.e. 'stable-5' so the subject can be something like:

[PATCH pve-container stable-5] fix ...

that makes it easier to realize when sorting through emails for review

> 
> Should i edit the PATCH?

yes, please make it '<= 9' to match with the current branch so we don't
have to do it one more time later :)

> 
> > On March 2, 2020 2:51 PM Oguz Bektas <o.bektas at proxmox.com> wrote:
> > 
> >  
> > hi,
> > 
> > i assume this is for the older 5.x branch. you should mention that in
> > your message.
> > 
> > in the 6.x branch this is already set to '<= 9' so you can do that here
> > as well.
> > 
> > On Mon, Mar 02, 2020 at 02:33:32PM +0100, Moayad Almalat wrote:
> > > Signed-off-by: Moayad Almalat <m.almalat at proxmox.com>
> > > ---
> > >  src/PVE/LXC/Setup/CentOS.pm | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
> > > index cc4c5bb..34430ff 100644
> > > --- a/src/PVE/LXC/Setup/CentOS.pm
> > > +++ b/src/PVE/LXC/Setup/CentOS.pm
> > > @@ -20,7 +20,7 @@ sub new {
> > >      my $version;
> > >  
> > >      if ($release =~ m/release\s+(\d+\.\d+)(\.\d+)?/) {
> > > -	if ($1 >= 5 && $1 <= 8) {
> > > +	if ($1 >= 5 && $1 <= 8.1) {
> > >  	    $version = $1;
> > >  	}
> > >      }
> > > -- 
> > > 2.20.1
> > > 
> > > _______________________________________________
> > > pve-devel mailing list
> > > pve-devel at pve.proxmox.com
> > > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> > > 
> > 
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel at pve.proxmox.com
> > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> best regards,
>  
> Moayad Alamalt
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>