[pve-devel] [PATCH qemu 2/2] Fix backup for not 64k-aligned storages

[Roland Kammerer]

On Mon, Jun 22, 2020 at 02:54:02PM +0200, Stefan Reiter wrote:
> Zero out clusters after the end of the device, this makes restore handle
> it correctly (even if it may try to write those zeros, it won't fail and
> just ignore the out-of-bounds write to disk).
> 
> For not even 4k-aligned disks, there is a potential buffer overrun in
> the memcpy (since always 4k are copied), which causes host-memory
> leakage into VMA archives. Fix this by always zeroing the affected area
> in the output-buffer.
> 
> Reported-by: Roland Kammerer <roland.kammerer at linbit.com>
> Suggested-by: Lars Ellenberg <lars.ellenberg at linbit.com>
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>

Hi Stefan,

as expected, on a DRBD device this did not complain on "verify" and the
restored data looks good, so:

Tested-by: Roland Kammerer <roland.kammerer at linbit.com>

Thanks, rck