[pve-devel] [PATCH pve-zsync 0/1] Allow pve-zsync jobs to share dest

Wolfgang Link w.link at proxmox.com
Mon Jun 22 13:43:45 CEST 2020


Look good to me
I tested it and it works. There are no upgrade problems. 
Even if jobs already exist.

Regards

Wolfgang

> On 06/17/2020 6:44 AM Wolfgang Link <w.link at proxmox.com> wrote:
> 
>  
> Hi,
> 
> thank you for this patch and the work.
> I will look at this patch and give you feedback.
> 
> Regards
> Wolfgang
> 
> > On 06/16/2020 8:53 PM Bruce Wainer <brwainer at gmail.com> wrote:
> > 
> >  
> > By flipping Source and Dest in snapshot_get and snapshot_exist, we can allow
> > multiple sync jobs to share the same source.
> > snapshot_get now checks the destination instead of source, and sets last_sync to
> > the last snapshot regardless of name. old_sync and whether to delete it is still
> > based on the job/name.
> > snapshot_exist now checks the source instead of the destination.
> > Other functions and/or their calls are changed to match the new situation.
> > 
> > Bruce Wainer (1):
> >   pve-zsync: Flip Source and Dest in functions to so jobs can share Dest
> > 
> >  pve-zsync | 42 +++++++++++++++++++++++++-----------------
> >  1 file changed, 25 insertions(+), 17 deletions(-)
> > 
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel at pve.proxmox.com
> > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Best Regards,
Wolfgang Link
w.link at proxmox.com
http://www.proxmox.com
____________________________________________________________________
Proxmox Server Solutions GmbH
Bräuhausgasse 37, 1050 Vienna, Austria
Commercial register no.: FN 258879 f
Registration office: Handelsgericht Wien




More information about the pve-devel mailing list