[pve-devel] [PATCH novnc-pve] POV: always request the server to generate a random password
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Jun 18 18:20:11 CEST 2020
Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
mostly sent along to have something to test this also with our implementation,
I'd not plan to adopt it during 6.x, for us it does not matters much after all
debian/patches/0001-add-pve-specific-js-code.patch | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/debian/patches/0001-add-pve-specific-js-code.patch b/debian/patches/0001-add-pve-specific-js-code.patch
index 44e62a5..7620610 100644
--- a/debian/patches/0001-add-pve-specific-js-code.patch
+++ b/debian/patches/0001-add-pve-specific-js-code.patch
@@ -11,7 +11,7 @@ autoresizing, commandstoggle, etc.
Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
- app/pve.js | 418 +++++++++++++++++++++++++++++++++++++++++++++++++++++
+ app/pve.js | 420 +++++++++++++++++++++++++++++++++++++++++++++++++++++
app/ui.js | 66 +++++++--
vnc.html | 10 +-
3 files changed, 480 insertions(+), 14 deletions(-)
@@ -22,7 +22,7 @@ new file mode 100644
index 0000000..e2c37fb
--- /dev/null
+++ b/app/pve.js
-@@ -0,0 +1,418 @@
+@@ -0,0 +1,420 @@
+/*
+ * PVE Utility functions for noVNC
+ * Copyright (C) 2017 Proxmox GmbH
@@ -43,7 +43,7 @@ index 0000000..e2c37fb
+
+ var baseUrl = '/nodes/' + this.nodename;
+ var url;
-+ var params = { websocket: 1 };
++ var params = { websocket: 1, 'generate-password': 1 };
+ var title;
+
+ switch (this.consoletype) {
@@ -382,7 +382,9 @@ index 0000000..e2c37fb
+ vncticket: result.data.ticket
+ });
+
-+ document.getElementById('noVNC_password_input').value = result.data.ticket;
++ let pass = result.data.ticket;
++ if (typeof result.data.password === "string") pass = result.data.password;
++ document.getElementById('noVNC_password_input').value = pass;
+ me.UI.forceSetting('path', 'api2/json' + me.baseUrl + '/vncwebsocket' + "?" + wsparams);
+
+ callback();
--
2.20.1
More information about the pve-devel
mailing list