[pve-devel] applied-series: Re: [PATCH v3 manager 1/2] vzdump: make guest include logic testable

[Thomas Lamprecht]

On 6/8/20 3:00 PM, Aaron Lauterer wrote:
> As a first step to make the whole guest include logic more testable the
> part from the API endpoint has been moved to its own method with as
> little changes as possible.
> 
> Everything concerning `all` and `exclude` logic is still in the
> PVE::VZDump->exec_backup() method.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> 
> v2 -> v3:
> * remove $self from get_included_guests
> * added `use` statement for API2Tools
> * fixed a regression introduced in the previous revision that would
>   skip the backup job completely if the --all flag was set
> 
> v1 -> v2:
> * fixed return value. Array refs inside an array lead to nested
>   arrays not working with `my ($foo, $bar) = method();`
> 
> 
> As talked with thomas on[0] and off list, this patch series is meant to
> have more confidence in the ongoing changes.
> 
> My other ongoing patch series [1] will move the all the logic, even the
> one in the `exec_backup()` method into one single method.
> 
> [0] https://pve.proxmox.com/pipermail/pve-devel/2020-April/042795.html
> [1] https://pve.proxmox.com/pipermail/pve-devel/2020-April/042753.html
> (new revision is on the way)
> 
>  PVE/API2/VZDump.pm | 36 ++++++------------------------------
>  PVE/VZDump.pm      | 37 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 43 insertions(+), 30 deletions(-)
> 
>

applied series, thanks!

Small followup, we normally do not use `${$vmids}[0]` to access elements of array
references, but rather `$vmids->[0]` both OK.