[pve-devel] [PATCH storage/manager] create zpools with stable disk paths

Stoiko Ivanov s.ivanov at proxmox.com
Thu Jun 4 13:50:51 CEST 2020


This patchset fixes #2777.

Creating zpools should be done using the more stable device paths instead
of /dev/sdX. The case where this was reported was:
* hotplugging 2 disks in a server
* creating the zpool
* rebooting (the disks got new assignments)

so a not too unusual use-case.

The logic for selecting the by-id link worked in my tests, and on my machine.
One alternative would be to not remove the wwn/eui links - functionality wise
it should work with them as well.

The fallback to the regular device-path was kept since we cannot assume
that all disks get a by-id path (learned from our installer and virtio-block
devices).

The manager patches could probably be squashed - can gladly send a v2
but am fine if you squash them while applying.

pve-storage:
Stoiko Ivanov (1):
  fix #2777 add by-id link to disk udev info

 PVE/API2/Disks/ZFS.pm                      | 4 ++--
 PVE/Diskmanage.pm                          | 8 ++++++++
 test/disk_tests/sas/disklist_expected.json | 3 ++-
 3 files changed, 12 insertions(+), 3 deletions(-)

pve-manager:
Stoiko Ivanov (3):
  fix #2777: create zpool with stable dev links
  adapt zfs pool creation layout for by-id links
  add by-id link as hidden column to disklist

 www/manager6/node/Disks.js |  8 ++++++++
 www/manager6/node/ZFS.js   | 22 ++++++++++++++++++----
 2 files changed, 26 insertions(+), 4 deletions(-)
-- 
2.20.1





More information about the pve-devel mailing list