[pve-devel] [PATCH manager] ui: reorder Makefile entries

[Dominik Csapak]

On 7/29/20 12:14 PM, Fabian Grünbichler wrote:
> On July 29, 2020 8:51 am, Dominik Csapak wrote:
>> most of the time alphabetically is ok, but some classes have to defined
>> earlier, else extjs does not find the class and tries to dynamically
>> load it via a http request. that fails, and in the end it still
>> finds the right classes (after loading the complete js file) but
>> we still get ugly error messages and http requests that are not necessary
>>
>> so we move some essential classes to the top
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>> has someone a better suggestion except manually managing the order?
> 
> split the list into two variables? one for the essential stuff with a
> comment, one for the sorted everything else..

well they all depend on each other, the rest just works
by accident, so adding a new one could mean we have to
move a bunch to the other variable...

> 
>>   www/manager6/Makefile | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/www/manager6/Makefile b/www/manager6/Makefile
>> index 4288acdd..bccd8c32 100644
>> --- a/www/manager6/Makefile
>> +++ b/www/manager6/Makefile
>> @@ -1,6 +1,9 @@
>>   include ../../defines.mk
>>   
>>   JSSRC= 							\
>> +	panel/ConfigPanel.js				\
>> +	panel/StatusView.js				\
>> +	window/Wizard.js				\
>>   	Parser.js					\
>>   	StateProvider.js				\
>>   	Toolkit.js					\
>> @@ -29,8 +32,8 @@ JSSRC= 							\
>>   	dc/ACLView.js					\
>>   	dc/ACMEClusterView.js				\
>>   	dc/ACMEPluginEdit.js				\
>> -	dc/AuthEditAD.js				\
>>   	dc/AuthEditBase.js				\
>> +	dc/AuthEditAD.js				\
>>   	dc/AuthEditLDAP.js				\
>>   	dc/AuthView.js					\
>>   	dc/Backup.js					\
>> @@ -154,7 +157,6 @@ JSSRC= 							\
>>   	node/Subscription.js				\
>>   	node/Summary.js					\
>>   	node/ZFS.js					\
>> -	panel/ConfigPanel.js				\
>>   	panel/GuestStatusView.js			\
>>   	panel/GuestSummary.js				\
>>   	panel/HealthWidget.js				\
>> @@ -163,7 +165,6 @@ JSSRC= 							\
>>   	panel/NotesView.js				\
>>   	panel/RunningChart.js				\
>>   	panel/StatusPanel.js				\
>> -	panel/StatusView.js				\
>>   	panel/TemplateStatusView.js			\
>>   	pool/Config.js					\
>>   	pool/StatusView.js				\
>> @@ -251,7 +252,6 @@ JSSRC= 							\
>>   	window/Settings.js				\
>>   	window/Snapshot.js				\
>>   	window/StartupEdit.js				\
>> -	window/Wizard.js				\
>>   # end of JSSRC list
>>   
>>   all: pvemanagerlib.js
>> -- 
>> 2.20.1
>>
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>
>>
>>
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>