[pve-devel] applied: [PATCH manager] fix #2890: also detect & renew DNS-only ACME certs

Fabian Grünbichler f.gruenbichler at proxmox.com
Mon Jul 27 10:55:35 CEST 2020


this call site was apparently missed when we refactored the node config
/ ACME interaction.

Suggested/Reported-by: Frédéric Bourqui
Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---
 bin/pveupdate | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bin/pveupdate b/bin/pveupdate
index 56d5d718..99b52fe9 100755
--- a/bin/pveupdate
+++ b/bin/pveupdate
@@ -60,7 +60,8 @@ if (my $err = $@) {
 
 eval {
     my $node_config = PVE::NodeConfig::load_config($nodename);
-    if ($node_config && $node_config->{acme}) {
+    my $acme_node_config = PVE::NodeConfig::get_acme_conf($node_config);
+    if ($acme_node_config && $acme_node_config->{domains}) {
 	my $cert = PVE::CertHelpers::cert_path_prefix($nodename).".pem";
 	if (-e $cert) {
 	    if (PVE::Certificate::check_expiry($cert, time() + 30*24*60*60)) {
-- 
2.20.1






More information about the pve-devel mailing list