[pve-devel] [PATCH v4 manager 0/5] add backup detail and not backed up view

Aaron Lauterer a.lauterer at proxmox.com
Tue Jul 7 11:48:57 CEST 2020


This series add a new detail view for backup jobs to show which volumes
of a guest would be included.

Additionally it adds a notification if there are any guests not covered
by any backup job with a new window showing these guests. This is to fix
#2609.

For the latter, a new API endpoint was needed because the already
existing `cluster/backup` expects a job ID on the next level. This makes
it hard to impossible to add other endpoints there. More details are in
the actual patch.


Changes from v3 -> v4:

* switched from summary view with its own button to notification if some
  guests are not backed up and changed the view to only include not
  backed up guests.
* added search boxes to both the detail tree view
* removed the "not permissions for all" notification. We don't do that
  anywhere else anyway and it makes the API return structure simpler and
  easier to deal with
* incorporated some code style changes such as creating the object to be
  pushed to the result array inline in the push operation instead of
  defining it way before


Aaron Lauterer (5):
  api: backup: add endpoint to list included guests and volumes
  gui: dc/backup: move renderers to Utils.js
  gui: dc/backup: add new backup job detail view
  fix #2609 api: backupinfo: add non job specific endpoint
  fix #2609 gui: backup: add window for not backed guests

 PVE/API2/Backup.pm        | 174 ++++++++++++
 PVE/API2/BackupInfo.pm    | 145 ++++++++++
 PVE/API2/Cluster.pm       |   6 +
 PVE/API2/Makefile         |   1 +
 www/manager6/Utils.js     |  94 +++++++
 www/manager6/dc/Backup.js | 574 ++++++++++++++++++++++++++++++++++----
 6 files changed, 936 insertions(+), 58 deletions(-)
 create mode 100644 PVE/API2/BackupInfo.pm

-- 
2.20.1






More information about the pve-devel mailing list