[pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Jul 7 08:51:45 CEST 2020


On July 7, 2020 8:36 am, Thomas Lamprecht wrote:
> On 07.07.20 08:24, Fabian Grünbichler wrote:
>> On July 7, 2020 6:42 am, Dietmar Maurer wrote:
>>>> so we have a 'termproxy' crate+binary and a binary package with name
>>>> 'pve-xtermjs'
>>>
>>> This is quite confusing ...
>> 
>> well, it replaces a 'pve-xtermjs' binary package that ships a 'termproxy'
>> binary (/CLIHandler). the alternative is to bump the old pve-xtermjs to 
>> become a transitional package depending on a new 'termproxy' 
>> (pve-termproxy? proxmox-termproxy?) package that ships the termproxy 
>> binary and breaks+replaces the old pve-xtermjs package..
> 
> the name is OK, IMO, it's just the same as before. The source package name
> is the only thing confusing to me, but I told Dominik already that we can
> do that like proxmox-backup, with our own control(.in) - but as we do not
> really use source package names yet, that confusion is now a bit secondary
> to me.

yes, but we only do control.in in proxmox-backup because debcargo does 
not support multiple binary packages (yet) ;) if we can avoid it, I'd 
avoid it.. if we absolutely have to, we can also just keep the changelog 
as it is and sed the 'Source' line in the generated d/control file..




More information about the pve-devel mailing list