[pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

[Thomas Lamprecht]

On 06.07.20 12:57, Dominik Csapak wrote:
> termproxy is now completely written in rust (instead of perl) but
> it is a drop-in replacement
> 
> this contains all other necessary changes to the build-system
> for it to successfully build
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> 
> changelog needs to be adapted to have 'rust-termproxy' as src
> package, since it seems that you cannot have a 'pve-xtermjs' package with
> a 'pve-xtermjs' crate but the binary is named 'termproxy'
> 
> so we have a 'termproxy' crate+binary and a binary package with name
> 'pve-xtermjs'
> 
> also the version in Cargo.toml needs then to be bumped to 4.7.0
> 

Looks good to me, single real issue I have with this is that lots of
stuff gets pulled in to compile only to be thrown away during linking
- most of tokio, hyper, ... Needing over 1.5 minutes build time for
such a simple tool is not really acceptable, IMO. But as it's not often
build I could live with that for now, if improving it is not easy/quick.

@Wolfgang, can you please use your rust wizard-hat and eyes and take a
closer look at the code?