[pve-devel] [PATCH 0/3] fix #2611: bandwidth limiting problems

Stefan Reiter s.reiter at proxmox.com
Tue Feb 25 16:31:59 CET 2020


#2611 is actually two separate issues:

* Migration bandwidth limit not taken into account

This is caused by passing the wrong 'operation' to get_bandwidth_limit, which
means it never reads the correct value from datacenter.cfg

I'm not sure if we changed the naming somewhere along the line (making it a
regression) or if it never worked to begin with, but right now it's definitely
broken.

* Units in Datacenter GUI for setting limits are wrong/confusing

backendUnit was not set, so values were being converted to Bytes/s (default for
pveBandwidthField), but interpreted as KiB/s on the backend.

Both issues are addressed in this series.


manager: Stefan Reiter (1):
  fix #2611: gui: use backendUnit and pretty renderer

 www/manager6/dc/OptionView.js | 38 +++++++++++++++++++++++++++++------
 1 file changed, 32 insertions(+), 6 deletions(-)

qemu-server: Stefan Reiter (1):
  fix #2611: use correct operation in get_bandwidth_limit

 PVE/QemuMigrate.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

container: Stefan Reiter (1):
  fix #2611: use correct operation in get_bandwidth_limit

 src/PVE/LXC/Migrate.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1



More information about the pve-devel mailing list