[pve-devel] [PATCH manager 2/2] ceph: increase allowed service names to 63 characters

Dominik Csapak d.csapak at proxmox.com
Mon Feb 24 15:22:47 CET 2020


On 2/24/20 2:45 PM, Fabian Grünbichler wrote:
> On February 24, 2020 12:01 pm, Dominik Csapak wrote:
>> according to rfc 1034[0], each label of a domain name can be 63 octets
>> so increase that limit in the api calls and in ceph_service_cmd
>>
>> users can now create ceph services on machines with hostnames
>> longer than 32 characters
> 
> why not have the same pattern like for monitor/.. creation? e.g.,
> createmon has:
> 
> pattern => '[a-zA-Z0-9]([a-zA-Z0-9\-]*[a-zA-Z0-9])?'
> 
> unless I misread, MGR and MDS have the same pattern.
> 

mhmm.. i'd argue that is wrong too, since systemd has an upper
limit of 256 characters, including suffix (although
this is only mentioned in [0], not in my locally installed
manpages, so i am not sure how accurate it is)

but i agree, we should use the same pattern in all places..

suggestions?

0: https://www.freedesktop.org/software/systemd/man/systemd.unit.html



More information about the pve-devel mailing list