[pve-devel] [PATCH v2 container] fix #2598: activate volumes before mounting in stop mode backup

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Feb 19 17:10:54 CET 2020


On Tue, Feb 18, 2020 at 02:38:52PM +0100, Oguz Bektas wrote:
> 'stop' mode deactivates the volumes (relevant for LVM backend), and
> they're not reactivated before trying to mount them for backup.
> 
> reactivating the volumes before the mount in 'stop' mode backup solves
> the issue.
> 
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>

Acked-by: Wolfgang Bumiller <w.bumiller at proxmox.com>

> ---
>  src/PVE/VZDump/LXC.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
> index 0260184..ed6daa2 100644
> --- a/src/PVE/VZDump/LXC.pm
> +++ b/src/PVE/VZDump/LXC.pm
> @@ -310,6 +310,7 @@ sub archive {
>      if ($task->{mode} eq 'stop') {
>  	my $rootdir = $default_mount_point;
>  	my $storage_cfg = $self->{storecfg};
> +	PVE::Storage::activate_volumes($storage_cfg, $task->{volids});

This we definitely need. Additionally, we can consider removing this
from prepare(). Do we maybe also want a 'skip-deactivate' flag for the
vm-stop call made from vzdump?

>  	foreach my $disk (@$disks) {
>  	    $disk->{dir} = "${rootdir}$disk->{mp}";
>  	    PVE::LXC::mountpoint_mount($disk, $rootdir, $storage_cfg, undef, $task->{rootuid}, $task->{rootgid});
> -- 
> 2.20.1



More information about the pve-devel mailing list