[pve-devel] applied: [RFC installer] Revert "drop unused policy-disable-rc.d"

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Feb 19 16:55:17 CET 2020


On 2/19/20 11:54 AM, Stoiko Ivanov wrote:
> This reverts commit 8ee12a1c34f9b5980cb382aa2bb01855349a10a5.
> 
> `policy-rc.d` invocation is still used by deb-systemd-invoke (1p), despite
> it's by now unfitting name.
> 
> The policy-rc.d script the installer placed into the chroot prevents the
> starting of services by (debianized) maintainer-scripts [0].
> This should reduce installation time on one hand, and on the other hand does
> mask errors in maintainer-scripts, which error out if no systemd is running
> (e.g. inside the chroot)
> 
> Noticed the problem, when testing an unrelated patch and running into
> an aborted installtion, due to a, already fixed, glitch (missing '||true')
> in pve-lxc's postinst script.
> 
> [0] https://people.debian.org/~hmh/invokerc.d-policyrc.d-specification.txt
>    (did not find anything more current, contradicting the information there)
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
> Sent as RFC because I'm not sure whether the tradeoff between:
> * forcing us to fix bugs in our maint-scripts
> * forcing us to deal with problems in upstream maint-scripts

while it seems like a pretty rad test harness it makes more sense to go back
to status quo, and if it be only because this should be a bit faster :-)
applied, thanks!



More information about the pve-devel mailing list